From what I see regarding 2008 128i vert wheel sizes, there was:
205/55R16 square setup for the BASE Model
OR 205/50R17 front on 7" wide rim w/ 225/45R17 rear on 7.5" rim for the Sports Package model.
From what I can see online, the stock offsets were 47mm on the 17 inch rims.
Did you want to go with a square setup (same rim/tire size) all around (good for rotation)?
This is a good reference to use when doing your calculations. You will need to measure key clearance points and input them into this calculator.
http://www.wheel-size.com/calc/?whe...35-18X8ET39&fcl=50mm&wcl=30mm&scl=50mm&sr=0mm
So I had stock setup on my 228i (225/40R18 on wheels with 45mm offset). I went with 245/35R18 with wheels with an offset of 40mm (ET40). Could have done ET41 or ET42 though as I had the room on the interior between the tire and suspension. But with this combination I have no rubbing.
The clearances may be different on the 128. You will need to get your ruler out!
Remember that going with a lower offset essentially pushes the wheel to the outside (i.e. the "Poke"), higher offset pulls the wheel in to the inside towards the suspension components. Best to keep the inner clearance close to stock as you do not want rubbing on the suspension components (Strut)... meaning you manipulate the two main variables - (1) the wheel offset and, (2) the wheel width (say going from 7" to 8"). Then the concern is clearance on the fender and when you lock steering to each side.
Also, when up sizing your tires, you want to keep very close to your original rolling diameter of your OEM tires - so your speedo isn't off.